compact_level0_phase1: ignore access mode config, always do streaming-kmerge without validation #8934
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
problame
changed the title
problame
changed the base branch from
problame/compaction-pagecache-bypass-default-to-no-validation
to
main
skyzh
approved these changes
Sep 5, 2024
3829 tests run: 3719 passed, 0 failed, 110 skipped (full report)Code coverage* (full report)
* collected from Rust tests only The comment gets automatically updated with the latest test results
6d52ee7 at 2024-09-05T16:53:00.671Z :recycle: |
problame
deleted the
problame/compaction-pagecache-bypass-remove-page-cached-blob-io-code-but-accept-config
branch
problame
added a commit
that referenced
this pull request
Sep 23, 2024
#8935) refs #8184 stacked atop #8934 This PR changes from ignoring the config field to rejecting configs that contain it. PR neondatabase/infra#1903 removes the field usage from `pageserver.toml`. It rolls into prod sooner or in the same release as this PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refs #8184
PR https://github.com/neondatabase/infra/pull/1905 enabled streaming-kmerge without validation everywhere.
It rolls into prod sooner or in the same release as this PR.