Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI(label-for-external-users): add retry logic for unexpected errors #8938

Merged
merged 2 commits into from
Sep 6, 2024

Conversation

bayandin
Copy link
Member

@bayandin bayandin commented Sep 5, 2024

Problem

One of the PRs[1] opened by a neondatabase org member got labelled as external because the gh api call failed in the wrong way[2]:

Get "https://api.github.com/orgs/neondatabase/members/cloneable": dial tcp 140.82.114.5:443: i/o timeout
is-member=false

Summary of changes

  • Check that the error message is expected before labelling PRs
  • Retry gh api call for 10 times in case of unexpected error messages
  • Add workflow_dispatch trigger

Checklist before requesting a review

  • I have performed a self-review of my code.
  • If it is a core feature, I have added thorough tests.
  • Do we need to implement analytics? if so did you add the relevant metrics to the dashboard?
  • If this PR requires public announcement, mark it with /release-notes label and add several sentences in this section.

Checklist before merging

  • Do not forget to reformat commit message to not include the above checklist

@bayandin bayandin requested a review from koivunej September 5, 2024 17:34
Copy link

github-actions bot commented Sep 5, 2024

3829 tests run: 3719 passed, 0 failed, 110 skipped (full report)


Flaky tests (2)

Postgres 16

Code coverage* (full report)

  • functions: 31.9% (7390 of 23138 functions)
  • lines: 50.3% (59657 of 118607 lines)

* collected from Rust tests only


The comment gets automatically updated with the latest test results
05a6157 at 2024-09-05T18:23:21.601Z :recycle:

Copy link
Member

@koivunej koivunej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not entirely sure if we need the retry loop, but you've already implemented it so lets enjoy it. I guess this will help to better debug any unexpected stuff as well.

@bayandin bayandin merged commit 30583cb into main Sep 6, 2024
72 checks passed
@bayandin bayandin deleted the bayandin/retry-errors-for-external-users branch September 6, 2024 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants