-
Notifications
You must be signed in to change notification settings - Fork 463
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add neon_local
subcommand for the broker & use that from regression tests
#8948
Conversation
5082 tests run: 4908 passed, 0 failed, 174 skipped (full report)Flaky tests (9)Postgres 17
Postgres 16
Postgres 15
Postgres 14
Code coverage* (full report)
* collected from Rust tests only The comment gets automatically updated with the latest test results
5c2acb7 at 2024-09-17T22:31:38.391Z :recycle: |
neon_local
subcommand for the broker & use that from regression tests
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. I believe CI only runs if the merge conflict is resolved.
…torage-broker-subcommand
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LTGM if tests pass 😄
Do we want to run benchmarks to see if there're ok?
There's currently no way to just start/stop broker from
neon_local
.This PR
subprocess
based approach.Found this useful during investigation https://github.com/neondatabase/cloud/issues/16886.