walredo: add a ping method #8952
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Immediate benefit: easier to spot what's going on. Later benefit: TBD PR that adds a `ping`.
hlinnaka
approved these changes
Sep 6, 2024
5003 tests run: 4839 passed, 0 failed, 164 skipped (full report)Flaky tests (4)Postgres 17
Postgres 15
Postgres 14
Code coverage* (full report)
* collected from Rust tests only The comment gets automatically updated with the latest test results
359cdc5 at 2024-09-23T10:29:22.125Z :recycle: |
jcsp
reviewed
Sep 8, 2024
jcsp
approved these changes
Sep 8, 2024
…to problame/walredo-add-ping-method
…e/neon into problame/walredo-add-ping-method
problame
requested review from
cloneable,
mikhail-sakhnov and
piercypixel
and removed request for
a team
Base automatically changed from
problame/walredo-refactor-launch-and-kill-machinery
to
main
September 17, 2024 19:16
problame
added a commit
that referenced
this pull request
Sep 17, 2024
Immediate benefit: easier to spot what's going on. Later benefit: use the extracted method in PR - #8952 which adds a `ping` command to walredo. Found this useful during investigation neondatabase/cloud#16886.
jcsp
approved these changes
Sep 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not used in production, but in benchmarks, to demonstrate minimal RTT.
(It would be nice to not have to copy the 8KiB of zeroes, but, that would require larger protocol changes).
Found this useful in investigation #8952.