Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove async_trait from the Handler trait #8958

Merged
merged 1 commit into from
Sep 10, 2024
Merged

Conversation

arpad-m
Copy link
Member

@arpad-m arpad-m commented Sep 7, 2024

Newest attempt to remove async_trait from the Handler trait.

Earlier attempts were in #7301 and #8296 .

Copy link

github-actions bot commented Sep 7, 2024

3883 tests run: 3768 passed, 1 failed, 114 skipped (full report)


Failures on Postgres 15

# Run all failed tests locally:
scripts/pytest -vv -n $(nproc) -k "test_storage_controller_heartbeats[release-pg15-failure4]"
Flaky tests (4)

Postgres 16

Postgres 15

Code coverage* (full report)

  • functions: 31.7% (7342 of 23149 functions)
  • lines: 50.0% (59471 of 119018 lines)

* collected from Rust tests only


The comment gets automatically updated with the latest test results
6136cf6 at 2024-09-08T12:36:53.560Z :recycle:

@arpad-m arpad-m marked this pull request as ready for review September 8, 2024 12:08
@arpad-m arpad-m requested review from a team as code owners September 8, 2024 12:08
@arpad-m arpad-m merged commit 9758217 into main Sep 10, 2024
73 checks passed
@arpad-m arpad-m deleted the arpad/async_trait_handler branch September 10, 2024 00:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants