Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prototype implementation for private access poc #8976

Merged
merged 5 commits into from
Sep 12, 2024

Conversation

stradig
Copy link
Contributor

@stradig stradig commented Sep 10, 2024

Problem

For the Private Access POC we want users to be able to disable access from the public proxy. To limit the number of changes this can be done by configuring an IP allowlist [ "255.255.255.255" ]. For the Private Access proxy a new commandline flag allows to disable IP allowlist completely.

See https://www.notion.so/neondatabase/Neon-Private-Access-POC-Proposal-8f707754e1ab4190ad5709da7832f020?d=887495c15e884aa4973f973a8a0a582a#7ac6ec249b524a74adbeddc4b84b8f5f for details about the POC.,

Summary of changes

  • Adding the commandline flag is_private_access_proxy=true will disable IP allowlist

Copy link

@orca-security-us orca-security-us bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Orca Security Scan Summary

Status Check Issues by priority
Passed Passed Infrastructure as Code high 0   medium 0   low 0   info 0 View in Orca
Passed Passed Secrets high 0   medium 0   low 0   info 0 View in Orca
Passed Passed Vulnerabilities high 0   medium 0   low 0   info 0 View in Orca

Copy link

github-actions bot commented Sep 10, 2024

3857 tests run: 3743 passed, 0 failed, 114 skipped (full report)


Flaky tests (5)

Postgres 15

Postgres 14

Code coverage* (full report)

  • functions: 31.7% (7354 of 23183 functions)
  • lines: 50.0% (59558 of 119169 lines)

* collected from Rust tests only


The comment gets automatically updated with the latest test results
638b856 at 2024-09-12T11:27:20.788Z :recycle:

@stradig stradig marked this pull request as ready for review September 12, 2024 07:25
@stradig stradig requested a review from a team as a code owner September 12, 2024 07:25
@stradig stradig requested a review from cloneable September 12, 2024 07:25
@stradig stradig merged commit fcab61b into main Sep 12, 2024
72 checks passed
@stradig stradig deleted the stefan/private_access_poc_proxy_changes branch September 12, 2024 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants