Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(storage-scrubber): log version after initialize the logger #9049

Merged
merged 1 commit into from
Sep 18, 2024

Conversation

skyzh
Copy link
Member

@skyzh skyzh commented Sep 18, 2024

Problem

When I checked the log in Grafana I couldn't find the scrubber version. Then I realized that it should be logged after the logger gets initialized.

Summary of changes

Log after initializing the logger for the scrubber.

Checklist before requesting a review

  • I have performed a self-review of my code.
  • If it is a core feature, I have added thorough tests.
  • Do we need to implement analytics? if so did you add the relevant metrics to the dashboard?
  • If this PR requires public announcement, mark it with /release-notes label and add several sentences in this section.

Checklist before merging

  • Do not forget to reformat commit message to not include the above checklist

Signed-off-by: Alex Chi Z <chi@neon.tech>
@skyzh skyzh requested review from a team and VladLazar and removed request for a team September 18, 2024 15:16
Copy link

4968 tests run: 4804 passed, 0 failed, 164 skipped (full report)


Flaky tests (4)

Postgres 17

Postgres 16

Postgres 15

Postgres 14

  • test_ondemand_wal_download_in_replication_slot_funcs: release-arm64

Code coverage* (full report)

  • functions: 31.8% (7416 of 23314 functions)
  • lines: 49.7% (59600 of 119808 lines)

* collected from Rust tests only


The comment gets automatically updated with the latest test results
ed5de88 at 2024-09-18T16:43:24.392Z :recycle:

@skyzh skyzh merged commit 9d1c6f2 into main Sep 18, 2024
80 checks passed
@skyzh skyzh deleted the skyzh/fix-scrubber-version branch September 18, 2024 18:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants