Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

impr(pageserver): log image layer creation #9050

Merged
merged 1 commit into from
Sep 19, 2024

Conversation

skyzh
Copy link
Member

@skyzh skyzh commented Sep 18, 2024

Problem

#9028 changed the image layer creation log into trace level. However, I personally find logging image layer creation useful when reading the logs -- it makes it clear that the image layer creation is happening and gives a clear idea of the progress. Therefore, I propose to continue logging them for create_image_layers set of functions.

Summary of changes

  • Add info logging for all image layers created in legacy compaction.
  • Add info logging for all layers creation in testing functions.

Checklist before requesting a review

  • I have performed a self-review of my code.
  • If it is a core feature, I have added thorough tests.
  • Do we need to implement analytics? if so did you add the relevant metrics to the dashboard?
  • If this PR requires public announcement, mark it with /release-notes label and add several sentences in this section.

Checklist before merging

  • Do not forget to reformat commit message to not include the above checklist

Signed-off-by: Alex Chi Z <chi@neon.tech>
@skyzh skyzh requested a review from hlinnaka September 18, 2024 15:22
@skyzh skyzh requested a review from a team as a code owner September 18, 2024 15:22
@skyzh skyzh requested a review from arssher September 18, 2024 15:22
Copy link

4968 tests run: 4804 passed, 0 failed, 164 skipped (full report)


Flaky tests (3)

Postgres 17

Postgres 16

Code coverage* (full report)

  • functions: 31.8% (7418 of 23314 functions)
  • lines: 49.7% (59604 of 119814 lines)

* collected from Rust tests only


The comment gets automatically updated with the latest test results
94ce7ec at 2024-09-18T17:04:36.634Z :recycle:

@skyzh skyzh merged commit ff9f065 into main Sep 19, 2024
80 checks passed
@skyzh skyzh deleted the skyzh/log-image-layer-creation branch September 19, 2024 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants