Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip running clippy in --release mode. #9073

Merged
merged 1 commit into from
Sep 20, 2024
Merged

Skip running clippy in --release mode. #9073

merged 1 commit into from
Sep 20, 2024

Conversation

hlinnaka
Copy link
Contributor

It's pretty expensive to run, and there is very little difference between debug and release builds that could lead to different clippy warnings.

This is extracted from PR #8912. That PR wandered off into various improvements we could make, but we seem to have consensus on this part at least.

It's pretty expensive to run, and there is very little difference
between debug and release builds that could lead to different clippy
warnings.

This is extracted from PR #8912. That PR wandered off into various
improvements we could make, but we seem to have consensus on this part
at least.
Copy link

github-actions bot commented Sep 20, 2024

4994 tests run: 4830 passed, 0 failed, 164 skipped (full report)


Flaky tests (7)

Postgres 17

Postgres 16

  • test_ondemand_wal_download_in_replication_slot_funcs: release-x86-64

Postgres 15

Postgres 14

Code coverage* (full report)

  • functions: 31.9% (7425 of 23300 functions)
  • lines: 49.8% (59759 of 119904 lines)

* collected from Rust tests only


The comment gets automatically updated with the latest test results
aad550f at 2024-09-20T13:57:58.662Z :recycle:

@hlinnaka hlinnaka merged commit 797aa4f into main Sep 20, 2024
84 checks passed
@hlinnaka hlinnaka deleted the run-clippy-less-2 branch September 20, 2024 14:23
davidgomes pushed a commit that referenced this pull request Sep 21, 2024
It's pretty expensive to run, and there is very little difference
between debug and release builds that could lead to different clippy
warnings.

This is extracted from PR #8912. That PR wandered off into various
improvements we could make, but we seem to have consensus on this part
at least.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants