neon_local: Use clap derive macros to parse the CLI args #9103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hlinnaka
force-pushed
the
use-clap-derive-for-neon_local
branch
2 times, most recently
from
c0d944d to
ed008e9
Compare
MMeent
reviewed
Sep 23, 2024
hlinnaka
force-pushed
the
use-clap-derive-for-neon_local
branch
from
ed008e9 to
4af95fb
Compare
5065 tests run: 4907 passed, 0 failed, 158 skipped (full report)Flaky tests (5)Postgres 17
Postgres 16
Code coverage* (full report)
* collected from Rust tests only The comment gets automatically updated with the latest test results
87d23fe at 2024-09-27T17:48:11.234Z :recycle: |
hlinnaka
force-pushed
the
use-clap-derive-for-neon_local
branch
3 times, most recently
from
0cd01d1 to
9c31fb1
Compare
hlinnaka
force-pushed
the
use-clap-derive-for-neon_local
branch
from
9c31fb1 to
fe436ef
Compare
This is easier to work with.
hlinnaka
force-pushed
the
use-clap-derive-for-neon_local
branch
from
fe436ef to
38d4d52
Compare
hlinnaka
requested review from
MMeent,
a team,
skyzh and
yliang412
and removed request for
a team
yliang412
reviewed
Sep 27, 2024
|
It would be awesome to get this done for compute_ctl as well, in the future. |
Co-authored-by: Yuchen Liang <70461588+yliang412@users.noreply.github.com>
bayandin
pushed a commit
that referenced
this pull request
Sep 29, 2024
This is easier to work with.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is easier to work with.