Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI(promote-images): fix prod ECR auth #9131

Merged
merged 1 commit into from
Sep 24, 2024
Merged

Conversation

bayandin
Copy link
Member

@bayandin bayandin commented Sep 24, 2024

Problem

Login to prod ECR doesn't work anymore:

Retrieving registries data through *** SDK...
*** ECR detected with eu-central-1 region
Error: The security token included in the request is invalid.

Ref https://github.com/neondatabase/neon/actions/runs/11015238522/job/30592994281

Tested https://github.com/neondatabase/neon/actions/runs/11017690614/job/30596213259#step:5:18 (on aae6182ff)

Summary of changes

  • Fix login to prod ECR by using aws-actions/configure-aws-credentials

Checklist before requesting a review

  • I have performed a self-review of my code.
  • If it is a core feature, I have added thorough tests.
  • Do we need to implement analytics? if so did you add the relevant metrics to the dashboard?
  • If this PR requires public announcement, mark it with /release-notes label and add several sentences in this section.

Checklist before merging

  • Do not forget to reformat commit message to not include the above checklist

@arpad-m arpad-m merged commit 7474790 into release Sep 24, 2024
33 of 46 checks passed
@arpad-m arpad-m deleted the bayandin/fix-promote-images branch September 24, 2024 16:34
bayandin added a commit that referenced this pull request Sep 25, 2024
## Problem
Login to prod ECR doesn't work anymore:
```
Retrieving registries data through *** SDK...
*** ECR detected with eu-central-1 region
Error: The security token included in the request is invalid.
```
Ref
https://github.com/neondatabase/neon/actions/runs/11015238522/job/30592994281

Tested
https://github.com/neondatabase/neon/actions/runs/11017690614/job/30596213259#step:5:18
(on aae6182ff)

## Summary of changes
- Fix login to prod ECR by using `aws-actions/configure-aws-credentials`
bayandin added a commit that referenced this pull request Sep 25, 2024
A cherry-pick from the previous release (#9131)

## Problem
Login to prod ECR doesn't work anymore:
```
Retrieving registries data through *** SDK...
*** ECR detected with eu-central-1 region
Error: The security token included in the request is invalid.
```

## Summary of changes
- Fix login to prod ECR by using `aws-actions/configure-aws-credentials`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants