Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: longer timeout in test_delete_timeline_client_hangup #9161

Merged
merged 2 commits into from
Sep 30, 2024

Conversation

jcsp
Copy link
Collaborator

@jcsp jcsp commented Sep 26, 2024

Problem

This test waits for a request to finish, and then expects deletion to complete almost immediately. The request completes, but it's a 202, the timeline is still deleting in the background: we need to be more patient.

Summary of changes

  • Adjust iterations from 2 to 10 when waiting for deletion

Checklist before requesting a review

  • I have performed a self-review of my code.
  • If it is a core feature, I have added thorough tests.
  • Do we need to implement analytics? if so did you add the relevant metrics to the dashboard?
  • If this PR requires public announcement, mark it with /release-notes label and add several sentences in this section.

Checklist before merging

  • Do not forget to reformat commit message to not include the above checklist

@jcsp jcsp added a/test Area: related to testing a/tech_debt Area: related to tech debt labels Sep 26, 2024
@jcsp jcsp marked this pull request as ready for review September 26, 2024 08:32
Copy link

github-actions bot commented Sep 26, 2024

5013 tests run: 4855 passed, 0 failed, 158 skipped (full report)


Flaky tests (2)

Postgres 17

Postgres 14

  • test_ondemand_wal_download_in_replication_slot_funcs: release-arm64

Code coverage* (full report)

  • functions: 31.4% (7484 of 23798 functions)
  • lines: 49.8% (60087 of 120696 lines)

* collected from Rust tests only


The comment gets automatically updated with the latest test results
3d1c3b9 at 2024-09-30T10:53:25.650Z :recycle:

@jcsp jcsp requested a review from bayandin September 30, 2024 08:29
@jcsp jcsp requested a review from arpad-m September 30, 2024 12:25
@jcsp jcsp self-assigned this Sep 30, 2024
@jcsp jcsp merged commit 7424e72 into main Sep 30, 2024
81 checks passed
@jcsp jcsp deleted the jcsp/delete-timeout branch September 30, 2024 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a/tech_debt Area: related to tech debt a/test Area: related to testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants