Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose more granular wait event data to the user #9163

Merged
merged 1 commit into from
Oct 2, 2024

Conversation

MMeent
Copy link
Contributor

@MMeent MMeent commented Sep 26, 2024

In PG17, there is this newfangled custom wait events system. This commit adds that feature to Neon, so that users can see what their backends may be waiting for when a PostgreSQL backend is playing the waiting game in Neon code.

Problem

We don't have very precise insights into what the backend is doing at each point in time.

Summary of changes

Add registration & naming for custom wait events where it makes sense to have them, so that we can see what the backends are waiting for.

Checklist before requesting a review

  • I have performed a self-review of my code.
  • If it is a core feature, I have added thorough tests.
  • Do we need to implement analytics? if so did you add the relevant metrics to the dashboard?
  • If this PR requires public announcement, mark it with /release-notes label and add several sentences in this section.

Checklist before merging

  • Do not forget to reformat commit message to not include the above checklist

@MMeent MMeent requested review from a team as code owners September 26, 2024 10:01
@MMeent MMeent requested review from hlinnaka and arssher September 26, 2024 10:01
Copy link

github-actions bot commented Sep 26, 2024

5065 tests run: 4901 passed, 0 failed, 164 skipped (full report)


Flaky tests (8)

Postgres 17

Postgres 16

Postgres 15

Postgres 14

Code coverage* (full report)

  • functions: 32.0% (7496 of 23396 functions)
  • lines: 50.1% (60500 of 120865 lines)

* collected from Rust tests only


The comment gets automatically updated with the latest test results
22fde9d at 2024-10-01T18:17:44.613Z :recycle:

In PG17, there is this newfangled custom wait events system. This commit
adds that feature to Neon, so that users can see what their backends may
be waiting for when a PostgreSQL backend is playing the waiting game in
Neon code.
@MMeent MMeent force-pushed the feat/custom-wait-events branch from 8cb3cb5 to 22fde9d Compare September 26, 2024 11:43
Copy link
Contributor

@hlinnaka hlinnaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ahh, I've been waiting to have these!

@MMeent MMeent merged commit ea32f1d into main Oct 2, 2024
80 checks passed
@MMeent MMeent deleted the feat/custom-wait-events branch October 2, 2024 09:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants