Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use long options when calling initdb #9174

Merged
merged 1 commit into from
Sep 27, 2024
Merged

Conversation

tristan957
Copy link
Member

Verbosity in this case is good when reading the code. Short options are better when operating in an interactive shell.

Verbosity in this case is good when reading the code. Short options are
better when operating in an interactive shell.

Signed-off-by: Tristan Partin <tristan@neon.tech>
Copy link

github-actions bot commented Sep 26, 2024

5065 tests run: 4906 passed, 1 failed, 158 skipped (full report)


Failures on Postgres 15

# Run all failed tests locally:
scripts/pytest -vv -n $(nproc) -k "test_storage_controller_heartbeats[release-pg15-failure4]"
Flaky tests (10)

Postgres 17

Postgres 15

Code coverage* (full report)

  • functions: 32.0% (7498 of 23402 functions)
  • lines: 50.0% (60540 of 120960 lines)

* collected from Rust tests only


The comment gets automatically updated with the latest test results
697d147 at 2024-09-26T21:29:36.118Z :recycle:

Copy link
Contributor

@yliang412 yliang412 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tristan957 tristan957 merged commit fc962c9 into main Sep 27, 2024
86 checks passed
@tristan957 tristan957 deleted the tristan957/initdb-long-opts branch September 27, 2024 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants