Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pageserver: refactor immediate_gc into TenantManager #9183

Merged
merged 1 commit into from
Sep 30, 2024
Merged

Conversation

jcsp
Copy link
Collaborator

@jcsp jcsp commented Sep 27, 2024

Problem

Legacy functions that were called as mgr:: and relied on the static TENANTS, see #5796

Summary of changes

  • Move the last stray function (immediate_gc) into TenantManager

Closes: #5796

Checklist before requesting a review

  • I have performed a self-review of my code.
  • If it is a core feature, I have added thorough tests.
  • Do we need to implement analytics? if so did you add the relevant metrics to the dashboard?
  • If this PR requires public announcement, mark it with /release-notes label and add several sentences in this section.

Checklist before merging

  • Do not forget to reformat commit message to not include the above checklist

@jcsp jcsp added c/storage/pageserver Component: storage: pageserver a/tech_debt Area: related to tech debt labels Sep 27, 2024
@jcsp jcsp requested a review from a team as a code owner September 27, 2024 16:52
@jcsp jcsp requested a review from yliang412 September 27, 2024 16:52
Copy link

5013 tests run: 4855 passed, 0 failed, 158 skipped (full report)


Flaky tests (4)

Postgres 17

Postgres 16

Postgres 15

  • test_ondemand_wal_download_in_replication_slot_funcs: release-x86-64

Postgres 14

Code coverage* (full report)

  • functions: 32.0% (7492 of 23433 functions)
  • lines: 49.9% (60494 of 121116 lines)

* collected from Rust tests only


The comment gets automatically updated with the latest test results
b926e62 at 2024-09-27T17:48:08.267Z :recycle:

@jcsp jcsp merged commit 7cfd116 into main Sep 30, 2024
84 checks passed
@jcsp jcsp deleted the jcsp/finish-5796 branch September 30, 2024 08:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a/tech_debt Area: related to tech debt c/storage/pageserver Component: storage: pageserver
Projects
None yet
Development

Successfully merging this pull request may close these issues.

pageserver: clean up public functions in mgr.rs
2 participants