-
Notifications
You must be signed in to change notification settings - Fork 463
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade OpenTelemetry and other tracing crates #9200
Conversation
9652b55
to
d7c1b0b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! I've almost done this a few times already as part of trying to reduce our dependencies, but never got around to finish it.
5039 tests run: 4881 passed, 0 failed, 158 skipped (full report)Flaky tests (2)Postgres 14
Code coverage* (full report)
* collected from Rust tests only The comment gets automatically updated with the latest test results
5780620 at 2024-09-30T18:14:15.510Z :recycle: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We now get a duplicate version of the 'prost' crate, but we can live with that. (IIRC I've gone down that rabbithole of trying to eliminate it and it was not easy...)
same... |
Yeah, it's usually impossible to dedup really everything, but the protobuf crates are on my list. I just didn't want to do too much in this PR. Thanks for the review! |
Layer
impl. Removes the need for crates toimport OTel crates.
assume the regular pipeline cannot be used/is broken.