Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

storage_scrubber: retry on index deletion failures #9204

Merged
merged 2 commits into from
Oct 1, 2024

Conversation

jcsp
Copy link
Collaborator

@jcsp jcsp commented Sep 30, 2024

Problem

In automated tests running on AWS S3, we frequently see scrubber failures when it can't delete an index.

location_conf_churn:
https://neon-github-public-dev.s3.amazonaws.com/reports/main/11076221056/index.html#/testresult/f89b1916b6a693e2

scrubber_physical_gc:
https://neon-github-public-dev.s3.amazonaws.com/reports/pr-9178/11074269153/index.html#/testresult/9885ed5aa0fe38b6

Summary of changes

Wrap index deletion in a backoff::retry

Checklist before requesting a review

  • I have performed a self-review of my code.
  • If it is a core feature, I have added thorough tests.
  • Do we need to implement analytics? if so did you add the relevant metrics to the dashboard?
  • If this PR requires public announcement, mark it with /release-notes label and add several sentences in this section.

Checklist before merging

  • Do not forget to reformat commit message to not include the above checklist

@jcsp jcsp added t/bug Issue Type: Bug c/storage/scrubber Component: s3_scrubber labels Sep 30, 2024
@jcsp jcsp self-assigned this Sep 30, 2024
Copy link

github-actions bot commented Sep 30, 2024

5013 tests run: 4855 passed, 0 failed, 158 skipped (full report)


Flaky tests (5)

Postgres 16

Postgres 14

Code coverage* (full report)

  • functions: 31.3% (7489 of 23890 functions)
  • lines: 49.6% (60107 of 121209 lines)

* collected from Rust tests only


The comment gets automatically updated with the latest test results
ef3db50 at 2024-10-01T08:30:36.404Z :recycle:

@jcsp jcsp requested a review from arpad-m September 30, 2024 15:07
@jcsp jcsp marked this pull request as ready for review September 30, 2024 15:07
storage_scrubber/src/pageserver_physical_gc.rs Outdated Show resolved Hide resolved
Co-authored-by: Arpad Müller <arpad-m@users.noreply.github.com>
@jcsp jcsp enabled auto-merge (squash) October 1, 2024 07:40
@jcsp jcsp merged commit 40b10b8 into main Oct 1, 2024
78 of 81 checks passed
@jcsp jcsp deleted the jcsp/tests-location-conf-churn branch October 1, 2024 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c/storage/scrubber Component: s3_scrubber t/bug Issue Type: Bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants