Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test_compatibility: fix the regexes detecting the version #9205

Merged
merged 1 commit into from
Sep 30, 2024

Conversation

a-masterov
Copy link
Contributor

@a-masterov a-masterov commented Sep 30, 2024

Problem

The Neon components, built locally and by the GitHub workflow have slightly different version prefixes (git: vs git-env:)
This does not allow running tests against local builds correctly.

Summary of changes

The regular expressions were changed to work with the both version prefixes.

Checklist before requesting a review

  • I have performed a self-review of my code.
  • If it is a core feature, I have added thorough tests.
  • Do we need to implement analytics? if so did you add the relevant metrics to the dashboard?
  • If this PR requires public announcement, mark it with /release-notes label and add several sentences in this section.

Checklist before merging

  • Do not forget to reformat commit message to not include the above checklist

@a-masterov a-masterov requested a review from bayandin September 30, 2024 13:21
@bayandin bayandin changed the title Fix the regexes detecting the version test_compatibility: fix the regexes detecting the version Sep 30, 2024
Copy link

5013 tests run: 4855 passed, 0 failed, 158 skipped (full report)


Flaky tests (2)

Postgres 16

Postgres 15

Code coverage* (full report)

  • functions: 31.5% (7488 of 23798 functions)
  • lines: 49.8% (60110 of 120696 lines)

* collected from Rust tests only


The comment gets automatically updated with the latest test results
e768f26 at 2024-09-30T14:17:01.553Z :recycle:

@a-masterov a-masterov merged commit 5dc68e4 into main Sep 30, 2024
81 checks passed
@a-masterov a-masterov deleted the amasterov/version-detection-in-tests branch September 30, 2024 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants