Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unnecessary dependencies from postgis-build image #9211

Merged
merged 3 commits into from
Oct 3, 2024

Conversation

hlinnaka
Copy link
Contributor

The apt install stage before this commit:

0 upgraded, 391 newly installed, 0 to remove and 9 not upgraded.
Need to get 261 MB of archives.

after:

0 upgraded, 367 newly installed, 0 to remove and 9 not upgraded.
Need to get 220 MB of archives.

Copy link

github-actions bot commented Sep 30, 2024

5022 tests run: 4864 passed, 0 failed, 158 skipped (full report)


Flaky tests (1)

Postgres 17

Code coverage* (full report)

  • functions: 31.3% (7485 of 23881 functions)
  • lines: 49.6% (60094 of 121224 lines)

* collected from Rust tests only


The comment gets automatically updated with the latest test results
8ec350d at 2024-10-01T20:17:00.951Z :recycle:

@hlinnaka hlinnaka requested review from a team, ololobus, bayandin and lubennikovaav and removed request for a team and ololobus September 30, 2024 21:05
Copy link
Member

@bayandin bayandin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!
Should we add --no-install-recommends to other apt installs?

For example, the postgis apt install stage before this commit:

    0 upgraded, 391 newly installed, 0 to remove and 9 not upgraded.
    Need to get 261 MB of archives.

after:

    0 upgraded, 367 newly installed, 0 to remove and 9 not upgraded.
    Need to get 220 MB of archives.
@hlinnaka hlinnaka force-pushed the reduce-postgis-build-image branch from 7107fb5 to 486da1e Compare October 1, 2024 17:46
@hlinnaka
Copy link
Contributor Author

hlinnaka commented Oct 1, 2024

Looks good! Should we add --no-install-recommends to other apt installs?

Good point. I added it to all of the apt installs now, let's see if everything still works.

@hlinnaka hlinnaka force-pushed the reduce-postgis-build-image branch from f8f7a7c to 1cb92a2 Compare October 1, 2024 18:19
@hlinnaka hlinnaka merged commit 6a9e2d6 into main Oct 3, 2024
79 checks passed
@hlinnaka hlinnaka deleted the reduce-postgis-build-image branch October 3, 2024 07:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants