Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ignore tonic to resolve advisories #9230

Merged
merged 1 commit into from
Oct 1, 2024
Merged

fix: ignore tonic to resolve advisories #9230

merged 1 commit into from
Oct 1, 2024

Conversation

skyzh
Copy link
Member

@skyzh skyzh commented Oct 1, 2024

Problem

check-rust-style fails because tonic version too old, this does not seem to be an easy fix, so ignore it from the deny list.

Summary of changes

Checklist before requesting a review

  • I have performed a self-review of my code.
  • If it is a core feature, I have added thorough tests.
  • Do we need to implement analytics? if so did you add the relevant metrics to the dashboard?
  • If this PR requires public announcement, mark it with /release-notes label and add several sentences in this section.

Checklist before merging

  • Do not forget to reformat commit message to not include the above checklist

@skyzh skyzh marked this pull request as ready for review October 1, 2024 21:30
Copy link

github-actions bot commented Oct 1, 2024

5022 tests run: 4864 passed, 0 failed, 158 skipped (full report)


Flaky tests (2)

Postgres 17

Postgres 15

Code coverage* (full report)

  • functions: 31.4% (7489 of 23881 functions)
  • lines: 49.6% (60102 of 121224 lines)

* collected from Rust tests only


The comment gets automatically updated with the latest test results
1891733 at 2024-10-01T22:41:43.195Z :recycle:

@skyzh skyzh changed the title fix: upgrade tonic to resolve advisories fix: ignore tonic to resolve advisories Oct 1, 2024
Signed-off-by: Alex Chi Z <chi@neon.tech>
@skyzh skyzh force-pushed the skyzh/upgrade-tonic branch from db458d4 to 1891733 Compare October 1, 2024 21:44
@skyzh skyzh requested review from conradludgate, a team and arpad-m and removed request for a team October 1, 2024 22:23
@skyzh skyzh merged commit 31f12f6 into main Oct 1, 2024
79 checks passed
@skyzh skyzh deleted the skyzh/upgrade-tonic branch October 1, 2024 23:26
@skyzh skyzh mentioned this pull request Oct 1, 2024
@skyzh
Copy link
Member Author

skyzh commented Oct 1, 2024

follow up: #9231

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants