Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: smaller layer changes #9247

Merged
merged 2 commits into from
Oct 3, 2024
Merged

chore: smaller layer changes #9247

merged 2 commits into from
Oct 3, 2024

Conversation

koivunej
Copy link
Member

@koivunej koivunej commented Oct 2, 2024

Address minor technical debt in Layer inspired by #9224:

  • layer usage as arg same as in spans
  • avoid one Weak::upgrade

@koivunej koivunej requested a review from a team as a code owner October 2, 2024 16:35
@koivunej koivunej requested review from arssher and jcsp and removed request for arssher October 2, 2024 16:35
@koivunej koivunej enabled auto-merge (squash) October 2, 2024 16:36
@koivunej koivunej disabled auto-merge October 2, 2024 16:39
@koivunej koivunej enabled auto-merge (squash) October 2, 2024 16:40
Copy link

github-actions bot commented Oct 2, 2024

5110 tests run: 4924 passed, 0 failed, 186 skipped (full report)


Flaky tests (5)

Postgres 17

Postgres 15

Code coverage* (full report)

  • functions: 31.4% (7491 of 23894 functions)
  • lines: 49.6% (60108 of 121293 lines)

* collected from Rust tests only


The comment gets automatically updated with the latest test results
ebd9bb8 at 2024-10-02T18:40:48.358Z :recycle:

@koivunej koivunej merged commit dbef1b0 into main Oct 3, 2024
82 checks passed
@koivunej koivunej deleted the joonas/small_layer_changes branch October 3, 2024 08:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants