Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(pageserver): do space check before gc-compaction #9250

Merged
merged 2 commits into from
Oct 17, 2024

Conversation

skyzh
Copy link
Member

@skyzh skyzh commented Oct 2, 2024

Problem

part of #9114

Summary of changes

gc-compaction may take a lot of disk space, and if it does, the caller should do a partial gc-compaction. This patch adds space check for the compaction job.

Checklist before requesting a review

  • I have performed a self-review of my code.
  • If it is a core feature, I have added thorough tests.
  • Do we need to implement analytics? if so did you add the relevant metrics to the dashboard?
  • If this PR requires public announcement, mark it with /release-notes label and add several sentences in this section.

Checklist before merging

  • Do not forget to reformat commit message to not include the above checklist

@skyzh skyzh force-pushed the skyzh/compaction-space-check branch from a8c76ff to fca44c2 Compare October 2, 2024 17:50
Copy link

github-actions bot commented Oct 2, 2024

5202 tests run: 4995 passed, 0 failed, 207 skipped (full report)


Flaky tests (5)

Postgres 17

Postgres 15

Postgres 14

Code coverage* (full report)

  • functions: 31.4% (7562 of 24115 functions)
  • lines: 49.2% (60484 of 122946 lines)

* collected from Rust tests only


The comment gets automatically updated with the latest test results
ccda7d7 at 2024-10-15T21:41:24.314Z :recycle:

@skyzh skyzh marked this pull request as ready for review October 2, 2024 19:31
@skyzh skyzh requested a review from a team as a code owner October 2, 2024 19:31
@skyzh skyzh requested review from problame and arpad-m October 2, 2024 19:31
Signed-off-by: Alex Chi Z <chi@neon.tech>
@skyzh skyzh force-pushed the skyzh/compaction-space-check branch from fca44c2 to def12b6 Compare October 15, 2024 20:49
Signed-off-by: Alex Chi Z <chi@neon.tech>
@skyzh skyzh force-pushed the skyzh/compaction-space-check branch from def12b6 to ccda7d7 Compare October 15, 2024 20:49
@skyzh skyzh requested a review from arpad-m October 15, 2024 20:50
@skyzh skyzh merged commit f3a3eef into main Oct 17, 2024
80 checks passed
@skyzh skyzh deleted the skyzh/compaction-space-check branch October 17, 2024 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants