Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add installed_extensions prometheus metric #9375

Closed
wants to merge 4 commits into from
Closed

Add installed_extensions prometheus metric #9375

wants to merge 4 commits into from

Conversation

lubennikovaav
Copy link
Contributor

@lubennikovaav lubennikovaav commented Oct 14, 2024 •
edited
Loading

and add /metrics endpoint to compute_ctl to expose such metrics

infra part: https://github.com/neondatabase/flux-fleet/pull/251

cc @oruen

@lubennikovaav
Add installed_extensions prometheus metric
b78e140 
and add /metrics endpoint to compute_ctl to expose such metrics
@lubennikovaav lubennikovaav requested review from a team as code owners October 14, 2024 09:33
@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 14, 2024 •
edited
Loading

5202 tests run: 4991 passed, 4 failed, 207 skipped (full report)

Failures on Postgres 15

# Run all failed tests locally:
scripts/pytest -vv -n $(nproc) -k "test_sliding_working_set_approximation[release-pg15] or test_slots_and_branching[release-pg15] or test_get_lsn_by_timestamp_cancelled[release-pg15] or test_subscriber_restart[release-pg15]"
Flaky tests (2)

Postgres 17

Postgres 15

Test coverage report is not available

The comment gets automatically updated with the latest test results
6ac7188 at 2024-10-16T16:25:24.594Z :recycle:

@lubennikovaav
Review fixes:
e7d9f92 
- do not use default collector,  collect only one metric;
- remove unit test, same behavior is covered by python test;
- code cleanup
@lubennikovaav
remove redundant labels
2575be6
lassizci
lassizci approved these changes Oct 15, 2024
View reviewed changes
Copy link
Contributor

@lassizci lassizci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good on my side!

@tristan957 tristan957 mentioned this pull request Oct 16, 2024
Merged
@lubennikovaav
Copy link
Contributor Author

Merged #9438
Pipeline will use logs instead of metrics.

@lubennikovaav lubennikovaav mentioned this pull request Nov 1, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oruen oruen oruen left review comments

@tristan957 tristan957 tristan957 approved these changes

@lassizci lassizci lassizci approved these changes

@mattpodraza mattpodraza Awaiting requested review from mattpodraza mattpodraza was automatically assigned from neondatabase/control-plane

@hlinnaka hlinnaka Awaiting requested review from hlinnaka hlinnaka is a code owner automatically assigned from neondatabase/compute

@ololobus ololobus Awaiting requested review from ololobus

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@lubennikovaav @oruen @lassizci @ololobus @tristan957