-
Notifications
You must be signed in to change notification settings - Fork 456
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(pageserver): support key range for manual compaction trigger #9723
Conversation
5534 tests run: 5308 passed, 0 failed, 226 skipped (full report)Code coverage* (full report)
* collected from Rust tests only The comment gets automatically updated with the latest test results
681fb1b at 2024-11-19T19:07:40.173Z :recycle: |
6aa7515
to
27e70aa
Compare
27e70aa
to
59c42fa
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Occupying the entire request body for just the CompactRange
will make it harder to extend the endpoint down the line.
I think it shouldn't be particularly hard/time consuming to move all the query fields (force_l0_compaction
, force_repartition
etc) into a struct TimelineCompactRequest
.
(The reason why it shouldn't be particularly time consuming is that the the only place where we're constructing the request is in the ps_http.timeline_compact()
implementation.
Please do bit that bullet here, much appreciated!
Other than that, this looks good. Approving so you can merge this before your weekend starts
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
two minor points
I think we should move all these compaction configs to the POST body. Given the compaction tests are now the only users for the API, we can change it as much as we want in the future (hopefully, in the next two week? as I'll probably add more options to the API and the current way of doing it is not manageable...) |
Signed-off-by: Alex Chi Z <chi@neon.tech>
Signed-off-by: Alex Chi Z <chi@neon.tech>
Signed-off-by: Alex Chi Z <chi@neon.tech>
Signed-off-by: Alex Chi Z <chi@neon.tech>
71b20cf
to
681fb1b
Compare
Problem
part of #9114, we want to be able to run partial gc-compaction in tests. In the future, we can also expand this functionality to legacy compaction, so that we can trigger compaction for a specific key range.
Summary of changes
CompactOptions
.