tests: Increase timeout in test_create_churn_during_restart #9736
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This test was seen to be flaky, e.g. at https://neon-github-public-dev.s3.amazonaws.com/reports/pr-9457/11804246485/index.html#suites/ec4311502db344eee91f1354e9dc839b/982bd121ea698414/. If I _reduce_ the timeout from 10s to 8s on my laptop, it reliably hits that timeout and fails. That suggests that the test is pretty close to the edge even when it passes. Let's bump up the timeout to 30 s to make it more robust. See also #9730, although the error message is different there.
hlinnaka
force-pushed
the
unflake-test_create_churn_during_restart
branch
from
5a21c20 to
2e14322
Compare
5 tasks
5382 tests run: 5162 passed, 0 failed, 220 skipped (full report)Flaky tests (3)Postgres 17
Code coverage* (full report)
* collected from Rust tests only The comment gets automatically updated with the latest test results
2e14322 at 2024-11-13T00:27:49.319Z :recycle: |
knizhnik
approved these changes
Nov 13, 2024
|
In the log linked, a timeline creation takes 5 seconds. I can see how that happens in CI when nodes are very overloaded, I'm a bit surprised it was readily reproducible on a (presumably fast) local laptop. |
jcsp
approved these changes
Nov 13, 2024
Not a very fast laptop, and I compile in debug mode, and using cranelift which probably creates even slower binaries :-). |
|
think there may be a real bug here, but don't mind bumping the timeout in the interim: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This test was seen to be flaky, e.g. at
https://neon-github-public-dev.s3.amazonaws.com/reports/pr-9457/11804246485/index.html#suites/ec4311502db344eee91f1354e9dc839b/982bd121ea698414/.
If I reduce the timeout from 10s to 8s on my laptop, it reliably hits that timeout and fails. That suggests that the test is pretty close to the edge even when it passes. Let's bump up the timeout to 30 s to make it more robust.
See also #9730, although the error message is different there.