Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename 'installed_extensions' metric to 'compute_installed_extensions' #9759

Merged
merged 2 commits into from
Nov 22, 2024

Conversation

lubennikovaav
Copy link
Contributor

@lubennikovaav lubennikovaav commented Nov 14, 2024

to keep it consistent with existing compute metrics.

flux-fleet change is not needed, because it doesn't have any filter by metric name for compute metrics.

@lubennikovaav lubennikovaav requested review from a team as code owners November 14, 2024 15:47
@lubennikovaav lubennikovaav requested review from nikitakalyanov, ololobus and oruen and removed request for nikitakalyanov November 14, 2024 15:47
Copy link
Member

@ololobus ololobus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we also need to open a flux-fleet PR as well

Copy link

github-actions bot commented Nov 14, 2024

5535 tests run: 5318 passed, 0 failed, 217 skipped (full report)


Code coverage* (full report)

  • functions: 31.4% (7955 of 25340 functions)
  • lines: 49.3% (63110 of 128009 lines)

* collected from Rust tests only


The comment gets automatically updated with the latest test results
5c4c87b at 2024-11-22T16:33:58.882Z :recycle:

@lubennikovaav lubennikovaav force-pushed the rename_installed_extensions_metric branch from d0a0d1e to 5c4c87b Compare November 22, 2024 15:30
@lubennikovaav lubennikovaav added this pull request to the merge queue Nov 22, 2024
Merged via the queue into main with commit 3245f7b Nov 22, 2024
78 checks passed
@lubennikovaav lubennikovaav deleted the rename_installed_extensions_metric branch November 22, 2024 19:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants