-
Notifications
You must be signed in to change notification settings - Fork 456
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move logic for ingest benchmark from GitHub workflow into python testcase #9762
Conversation
…eondatabase/neon into bodobolero/ingest_bench_python
5499 tests run: 5273 passed, 0 failed, 226 skipped (full report)Code coverage* (full report)
* collected from Rust tests only The comment gets automatically updated with the latest test results
8dab650 at 2024-11-19T09:50:17.038Z :recycle: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've added a couple of comments where I spot a different approach with the current setup of performance tests
…ityl using inputs
… part of test result
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
Added a couple of comments, most of them for consistency with other benchmarks
Problem
The first version of the ingest benchmark had some parsing and reporting logic in shell script inside GitHub workflow.
it is better to move that logic into a python testcase so that we can also run it locally.
Summary of changes
Create new python testcase
invoke pgcopydb inside python test case
move the following logic into python testcase
add additional column to perf test database that can receive endpoint ID used for pgcopydb run to have it available in grafana dashboard when retrieving other metrics for an endpoint
Example run
https://github.com/neondatabase/neon/actions/runs/11860622170/job/33056264386