Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

proxy: Refactor http conn pool #9785

Merged
merged 1 commit into from
Nov 20, 2024
Merged

proxy: Refactor http conn pool #9785

merged 1 commit into from
Nov 20, 2024

Conversation

awarus
Copy link
Contributor

@awarus awarus commented Nov 18, 2024

  • Use the same ConnPoolEntry for http connection pool.
  • Rename EndpointConnPool to the HttpConnPool.
  • Narrow clone bound for client

Fixes #9284

@awarus awarus requested a review from a team as a code owner November 18, 2024 10:03
@awarus awarus requested a review from cloneable November 18, 2024 10:03
conradludgate
conradludgate reviewed Nov 18, 2024
View reviewed changes
proxy/src/serverless/http_conn_pool.rs Outdated Show resolved Hide resolved
proxy/src/serverless/http_conn_pool.rs Outdated Show resolved Hide resolved
proxy/src/serverless/http_conn_pool.rs Outdated Show resolved Hide resolved
proxy/src/serverless/http_conn_pool.rs Outdated Show resolved Hide resolved
proxy/src/serverless/conn_pool_lib.rs Outdated Show resolved Hide resolved
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 18, 2024 •
edited
Loading

5535 tests run: 5309 passed, 0 failed, 226 skipped (full report)

Code coverage* (full report)

  • functions: 31.4% (7939 of 25317 functions)
  • lines: 49.3% (63037 of 127839 lines)

* collected from Rust tests only

The comment gets automatically updated with the latest test results
a4e9882 at 2024-11-20T19:42:50.410Z :recycle:

@awarus awarus requested a review from conradludgate November 18, 2024 17:03
@awarus awarus force-pushed the http_conn_pool branch 2 times, most recently from 8490b24 to c1a4c80 Compare November 19, 2024 16:56
@awarus
proxy: Refactor http conn pool
a4e9882 
- Use the same ConnPoolEntry for http connection pool.
- Rename EndpointConnPool to the HttpConnPool.
- Use common GlobalConnPool

Fixes #9284
@awarus awarus added this pull request to the merge queue Nov 20, 2024
Merged via the queue into main with commit 2d6bf17 Nov 20, 2024
74 checks passed
@awarus awarus deleted the http_conn_pool branch November 20, 2024 19:37
@awarus awarus mentioned this pull request Nov 21, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@conradludgate conradludgate conradludgate approved these changes

@cloneable cloneable Awaiting requested review from cloneable cloneable is a code owner automatically assigned from neondatabase/proxy

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[tech debt] proxy: abstract away connection pools
2 participants
@awarus @conradludgate