Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

scrubber: fix parsing issue with Azure #9797

Merged
merged 1 commit into from
Nov 19, 2024
Merged

scrubber: fix parsing issue with Azure #9797

merged 1 commit into from
Nov 19, 2024

Conversation

arpad-m
Copy link
Member

@arpad-m arpad-m commented Nov 19, 2024

Apparently Azure returns timelines ending with / which confuses the parsing. So remove all trailing /s before attempting to parse.

Part of https://github.com/neondatabase/cloud/issues/19963

@arpad-m arpad-m requested a review from a team as a code owner November 19, 2024 03:46
@arpad-m arpad-m requested a review from skyzh November 19, 2024 03:46
Copy link

5499 tests run: 5273 passed, 0 failed, 226 skipped (full report)


Flaky tests (1)

Postgres 15

Code coverage* (full report)

  • functions: 31.5% (7937 of 25219 functions)
  • lines: 49.6% (62966 of 126919 lines)

* collected from Rust tests only


The comment gets automatically updated with the latest test results
4750f02 at 2024-11-19T04:45:32.613Z :recycle:

Copy link
Member

@skyzh skyzh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM given it passes all tests (we run scrubber at the end of many tests) but I'm skeptical why this works 🤣

storage_scrubber/src/metadata_stream.rs Show resolved Hide resolved
@arpad-m arpad-m merged commit b092126 into main Nov 19, 2024
80 checks passed
@arpad-m arpad-m deleted the arpad/scrubber_azure branch November 19, 2024 19:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants