Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

proxy: Rename RequestMonitoring to RequestContext #9805

Merged
merged 1 commit into from
Nov 20, 2024

Conversation

cloneable
Copy link
Contributor

Problem

It is called context/ctx everywhere and the Monitoring suffix needlessly confuses with proper monitoring code.

Summary of changes

  • Rename RequestMonitoring to RequestContext
  • Rename RequestMonitoringInner to RequestContextInner

It is called context/ctx everywhere and the Monitoring suffix
needlessly confuses with proper monitoring code.
@cloneable cloneable requested a review from a team as a code owner November 19, 2024 18:32
@conradludgate
Copy link
Contributor

Lol. I was told initially that the RequestContext name was confusing, so I renamed it :D 2146bcf

Copy link

5499 tests run: 5273 passed, 0 failed, 226 skipped (full report)


Flaky tests (1)

Postgres 17

Code coverage* (full report)

  • functions: 31.4% (7932 of 25224 functions)
  • lines: 49.6% (62945 of 126930 lines)

* collected from Rust tests only


The comment gets automatically updated with the latest test results
6d41d7e at 2024-11-19T19:31:39.498Z :recycle:

@cloneable
Copy link
Contributor Author

Lol. I was told initially that the RequestContext name was confusing, so I renamed it :D 2146bcf

Oh, interesting! I think RequestContext is just right and a very common name. I have never seen RequestMonitoring for something like this, but I see the point. Both RequestInfo or RequestMetadata still seem better, though. I'll think about this a bit more.

@cloneable cloneable added this pull request to the merge queue Nov 20, 2024
Merged via the queue into main with commit bf7d859 Nov 20, 2024
80 checks passed
@cloneable cloneable deleted the cloneable/proxy-rename-requestmonitoring branch November 20, 2024 12:51
@awarus awarus mentioned this pull request Nov 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants