Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI(release): create reusable workflow for releases #9806

Merged
merged 4 commits into from
Nov 19, 2024

Conversation

bayandin
Copy link
Member

@bayandin bayandin commented Nov 19, 2024

Problem

We have a bunch of duplicated code for automated releases. There will be even more once we have release-compute branch (#9637).

Another issue with the current release workflow is that it creates a PR from the main as is. In case we create 2 different releases from the same commit, GitHub could mix up results from different PRs.
An internal example: https://neondb.slack.com/archives/C036U0GRMRB/p1732026358686539

Summary of changes

  • Create a reusable workflow for releases
  • Create an empty commit to differentiate releases

Tested: https://github.com/neondatabase/neon/actions/runs/11920553827/job/33222747567 / #9807

@bayandin bayandin requested a review from a team November 19, 2024 19:30
@bayandin bayandin force-pushed the bayandin/reusable-workflow-for-releases branch from 96c266a to fba2687 Compare November 19, 2024 19:44
Copy link

5508 tests run: 5282 passed, 0 failed, 226 skipped (full report)


Code coverage* (full report)

  • functions: 31.4% (7939 of 25247 functions)
  • lines: 49.6% (63009 of 127010 lines)

* collected from Rust tests only


The comment gets automatically updated with the latest test results
efb84cd at 2024-11-19T20:51:06.023Z :recycle:

Copy link
Contributor

@fedordikarev fedordikarev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

@bayandin bayandin merged commit 725e0a1 into main Nov 19, 2024
81 checks passed
@bayandin bayandin deleted the bayandin/reusable-workflow-for-releases branch November 19, 2024 23:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants