Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

scan_log_for_errors: check that regex is correct #9815

Merged
merged 1 commit into from
Nov 20, 2024
Merged

Conversation

bayandin
Copy link
Member

@bayandin bayandin commented Nov 20, 2024

Problem

I've noticed that we have 2 flaky tests which failed with error:

re.error: missing ), unterminated subpattern at position 21
  • test_timeline_archival_chaos — has been fixed in db743a8
  • test_sharded_tad_interleaved_after_partial_success — I didn't manage to find the incorrect regex

Internal link

Summary of changes

  • Wrap re.match in try..except block and print incorrect regex

@bayandin bayandin requested a review from jcsp November 20, 2024 00:40
Copy link

5517 tests run: 5291 passed, 0 failed, 226 skipped (full report)


Code coverage* (full report)

  • functions: 31.4% (7937 of 25247 functions)
  • lines: 49.6% (62999 of 127010 lines)

* collected from Rust tests only


The comment gets automatically updated with the latest test results
2e3a763 at 2024-11-20T01:40:19.648Z :recycle:

@bayandin bayandin requested a review from a team November 20, 2024 12:09
@bayandin bayandin added this pull request to the merge queue Nov 20, 2024
Merged via the queue into main with commit 899933e Nov 20, 2024
80 checks passed
@bayandin bayandin deleted the bayandin/check-regex branch November 20, 2024 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants