Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(proxy): demote more logs during successful connection attempts #9828

Merged
merged 3 commits into from
Nov 20, 2024

Conversation

conradludgate
Copy link
Contributor

Follow up to #9803

See https://github.com/neondatabase/cloud/issues/14378

In collaboration with @cloneable and @awarus, we sifted through logs and simply demoted some logs to debug. This is not at all finished and there are more logs to review, but we ran out of time in the session we organised. In any slightly more nuanced cases, we didn't touch the log, instead leaving a TODO comment.

I've also slightly refactored the sql-over-http body read/length reject code. I can split that into a separate PR. It just felt natural after I switched to read_body_with_limit as we discussed during the meet.

@conradludgate conradludgate requested a review from a team as a code owner November 20, 2024 16:32
Copy link
Contributor

@awarus awarus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@conradludgate conradludgate added this pull request to the merge queue Nov 20, 2024
Merged via the queue into main with commit f36f006 Nov 20, 2024
76 checks passed
@conradludgate conradludgate deleted the conrad/reduce-more-proxy-info-logs branch November 20, 2024 17:51
Copy link

5535 tests run: 5309 passed, 0 failed, 226 skipped (full report)


Flaky tests (2)

Postgres 15

Postgres 14

Code coverage* (full report)

  • functions: 31.4% (7938 of 25310 functions)
  • lines: 49.3% (62998 of 127803 lines)

* collected from Rust tests only


The comment gets automatically updated with the latest test results
8ff8efa at 2024-11-20T17:57:07.215Z :recycle:

@awarus awarus mentioned this pull request Nov 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants