Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(proxy/jwks): reduce the rightward drift of jwks renewal #9853

Merged
merged 4 commits into from
Nov 22, 2024

Conversation

conradludgate
Copy link
Contributor

I found the rightward drift of the renew_jwks function hard to review.

This PR splits out some major logic and uses early returns to make the happy path more linear.

@conradludgate conradludgate requested a review from a team as a code owner November 22, 2024 12:57
Copy link

github-actions bot commented Nov 22, 2024

5561 tests run: 5344 passed, 0 failed, 217 skipped (full report)


Flaky tests (2)

Postgres 17

Postgres 14

Code coverage* (full report)

  • functions: 31.4% (7955 of 25340 functions)
  • lines: 49.3% (63102 of 128007 lines)

* collected from Rust tests only


The comment gets automatically updated with the latest test results
2f1cdea at 2024-11-22T15:02:06.714Z :recycle:

@conradludgate conradludgate added this pull request to the merge queue Nov 22, 2024
Merged via the queue into main with commit 8ab96cc Nov 22, 2024
78 checks passed
@conradludgate conradludgate deleted the conrad/jwks-rightward-drift branch November 22, 2024 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants