storcon_cli tenant-describe: include tenant-wide information in output #9899
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sadly, the tenant config doesn't skip on None, so, the output becomes a bit bloated.
7018 tests run: 6710 passed, 0 failed, 308 skipped (full report)Flaky tests (3)Postgres 16
Postgres 14
Code coverage* (full report)
* collected from Rust tests only The comment gets automatically updated with the latest test results
ef70a70 at 2024-12-02T16:03:22.143Z :recycle: |
jcsp
reviewed
Dec 2, 2024
jcsp
reviewed
Dec 2, 2024
jcsp
approved these changes
Dec 2, 2024
awarus
pushed a commit
that referenced
this pull request
Dec 5, 2024
#9899) Before this PR, the storcon_cli didn't have a way to show the tenant-wide information of the TenantDescribeResponse. Sadly, the `Serialize` impl for the tenant config doesn't skip on `None`, so, the output becomes a bit bloated. Maybe we can use `skip_serializing_if(Option::is_none)` in the future. => #9983
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this PR, the storcon_cli didn't have a way to show the tenant-wide information of the TenantDescribeResponse.
Sadly, the
Serializeimpl for the tenant config doesn't skip onNone, so, the output becomes a bit bloated.Maybe we can use
skip_serializing_if(Option::is_none)in the future.=> #9983