chore(proxy): vendor a subset of rust-postgres

[conradludgate]

Our rust-postgres fork is getting messy. Mostly because proxy wants more control over the raw protocol than tokio-postgres provides. As such, it's diverging more and more. Storage and compute also make use of rust-postgres, but in more normal usage, thus they don't need our crazy changes.

Idea:

• proxy maintains their subset
• other teams use a minimal patch set against upstream rust-postgres

Reviewing this code will be difficult. To implement it, I

1. Copied tokio-postgres, postgres-protocol and postgres-types from https://github.com/neondatabase/rust-postgres/tree/00940fcdb57a8e99e805297b75839e7c4c7b1796
2. Updated their package names with the 2 suffix to make them compile in the workspace.
3. Updated proxy to use those packages
4. Copied in the code from tokio-postgres-rustls 0.13 (with some patches applied correctly parse x509 certificates for channel binding jbg/tokio-postgres-rustls#32 remove unsafe code jbg/tokio-postgres-rustls#33)
5. Removed as much dead code as I could find in the vendored libraries
6. Updated the tokio-postgres-rustls code to use our existing channel binding implementation

[github-actions]

6310 tests run: 6020 passed, 0 failed, 290 skipped (full report)

---

Flaky tests (3)

Postgres 15

• test_cli_start_stop: release-arm64

Postgres 14

• test_cli_start_stop: release-arm64
• test_pull_timeline[True]: release-arm64

Code coverage* (full report)

• functions: 30.2% (8177 of 27038 functions)
• lines: 47.7% (64724 of 135801 lines)

* collected from Rust tests only

---

_{The comment gets automatically updated with the latest test results
4abd7b0 at 2024-11-28T19:39:23.469Z :recycle:}

[conradludgate]

Future planned changes:

• Re-apply https://github.com/neondatabase/rust-postgres/pull/30/files
• Make canceltokens public so we can store the state in redis
• Potential optimisations

[conradludgate]

This is a net reduction in code to maintain. Instead of maintaining the full fork of rust-postgres

===============================================================================
 Language            Files        Lines         Code     Comments       Blanks
===============================================================================
 Shell                   1          102           90            5            7
 Plain Text              1          497            0          410           87
 TOML                   10          315          280            0           35
 YAML                    1           10           10            0            0
-------------------------------------------------------------------------------
 Markdown                8          790            0          472          318
 |- Rust                 1           15           15            0            0
 (Total)                            805           15          472          318
-------------------------------------------------------------------------------
 Rust                  120        22627        19331           95         3201
 |- Markdown            55         2874           72         2346          456
 (Total)                          25501        19403         2441         3657
===============================================================================
 Total                 141        24341        19711          982         3648
===============================================================================

We only need to maintain a relatively simple patch set of 1600 lines and this new set of code

===============================================================================
 Language            Files        Lines         Code     Comments       Blanks
===============================================================================
 Markdown                1            6            0            4            2
 TOML                    3           52           48            0            4
-------------------------------------------------------------------------------
 Rust                   41         9708         8212           74         1422
 |- Markdown            29         1201            0         1071          130
 (Total)                          10909         8212         1145         1552
===============================================================================
 Total                  45         9766         8260           78         1428
===============================================================================

8260 + 1600 << 19711

[cloneable]

Looks good. Nice work!

I didn't review every line, not even every file. We will need to rely on testing here.

You added the rustls module to proxy proper so the new crates are and stay crypto provider agnostic?

[conradludgate]

You added the rustls module to proxy proper so the new crates are and stay crypto provider agnostic?

There wasn't much reason to it for now. Just needed to get it to compile. I could have put it in it's own crate or even into tokio-postgres directly. I didn't think much about it at the time. We can shuffle stuff around later