Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tests: make storcon scale test AZ-aware #9952

Merged
merged 1 commit into from
Dec 4, 2024
Merged

tests: make storcon scale test AZ-aware #9952

merged 1 commit into from
Dec 4, 2024

Conversation

jcsp
Copy link
Collaborator

@jcsp jcsp commented Nov 29, 2024

Problem

We have a scale test for the storage controller which also acts as a good stress test for scheduling stability. However, it created nodes with no AZs set.

Summary of changes

  • Bump node count to 6 and set AZs on them.

This is a precursor to other AZ-related PRs, to make sure any new code that's landed is getting scale tested in an AZ-aware environment.

@jcsp jcsp added a/test Area: related to testing run-benchmarks Indicates to the CI that benchmarks should be run for PR marked with this label c/storage/controller Component: Storage Controller labels Nov 29, 2024
@github-actions GitHub Actions
Copy link

7070 tests run: 6736 passed, 1 failed, 333 skipped (full report)

Failures on Postgres 16

  • test_sharded_ingest[github-actions-selfhosted-vanilla-1]: release-x86-64
# Run all failed tests locally:
scripts/pytest -vv -n $(nproc) -k "test_sharded_ingest[release-pg16-github-actions-selfhosted-vanilla-1]"
Flaky tests (4)

Postgres 17

Postgres 16

  • test_pgdata_import_smoke[None-1024-RelBlockSize.MULTIPLE_RELATION_SEGMENTS]: release-arm64

Code coverage* (full report)

  • functions: 30.3% (8184 of 27046 functions)
  • lines: 47.7% (64865 of 135976 lines)

* collected from Rust tests only

The comment gets automatically updated with the latest test results
921b2e9 at 2024-11-29T21:16:16.504Z :recycle:

@jcsp jcsp marked this pull request as ready for review December 2, 2024 12:11
@jcsp jcsp requested a review from VladLazar December 2, 2024 17:16
VladLazar
VladLazar approved these changes Dec 3, 2024
View reviewed changes
Copy link
Contributor

@VladLazar VladLazar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I assume some AZ specific assertions will come later?

@jcsp
Copy link
Collaborator Author

jcsp commented Dec 4, 2024

Looks good. I assume some AZ specific assertions will come later?
Yep

@jcsp jcsp added this pull request to the merge queue Dec 4, 2024
Merged via the queue into main with commit 60c0d19 Dec 4, 2024
89 of 90 checks passed
@jcsp jcsp deleted the jcsp/azs-scale-test branch December 4, 2024 15:06
awarus pushed a commit that referenced this pull request Dec 5, 2024
@jcsp @awarus
tests: make storcon scale test AZ-aware (#9952)
088eb72 
## Problem

We have a scale test for the storage controller which also acts as a
good stress test for scheduling stability. However, it created nodes
with no AZs set.

## Summary of changes

- Bump node count to 6 and set AZs on them.

This is a precursor to other AZ-related PRs, to make sure any new code
that's landed is getting scale tested in an AZ-aware environment.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@VladLazar VladLazar VladLazar approved these changes

Assignees
No one assigned
Labels
a/test Area: related to testing c/storage/controller Component: Storage Controller run-benchmarks Indicates to the CI that benchmarks should be run for PR marked with this label
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jcsp @VladLazar