Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

optimize parms for ingest bench #9999

Merged
merged 12 commits into from
Dec 4, 2024
Merged

optimize parms for ingest bench #9999

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
72441d1
test additional pgcopydb parallelism
Bodobolero Nov 28, 2024
4008e03
try parallel 6 jobs
Bodobolero Nov 28, 2024
0a4dc04
fix typo
Bodobolero Nov 29, 2024
94b8c64
trying 4 again
Bodobolero Nov 29, 2024
cd10fc6
allow to manually modify project after creation by sleeping for 5 min…
Bodobolero Nov 29, 2024
0dc5424
temporarily only use new project
Bodobolero Nov 29, 2024
cc3e297
reactivate large
Bodobolero Dec 2, 2024
8baa974
re-run with 10 GB chunks
Bodobolero Dec 3, 2024
78e262a
allow one job to fail and the other to continue
Bodobolero Dec 3, 2024
3fa4022
increase parallelism to 6 jobs, 12 workers
Bodobolero Dec 4, 2024
e5b8033
settings that have shown the best performance so far
Bodobolero Dec 4, 2024
62d3281
remove sleeping
Bodobolero Dec 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .github/workflows/ingest_benchmark.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@ concurrency:
jobs:
ingest:
strategy:
fail-fast: false # allow other variants to continue even if one fails
matrix:
target_project: [new_empty_project, large_existing_project]
permissions:
Expand Down
10 changes: 5 additions & 5 deletions test_runner/performance/test_perf_ingest_using_pgcopydb.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,13 +60,13 @@ def build_pgcopydb_command(pgcopydb_filter_file: Path, test_output_dir: Path):
"--no-acl",
"--skip-db-properties",
"--table-jobs",
"8",
"4",
"--index-jobs",
"8",
"4",
"--restore-jobs",
"8",
"4",
"--split-tables-larger-than",
"5GB",
"10GB",
"--skip-extensions",
"--use-copy-binary",
"--filters",
Expand Down Expand Up @@ -136,7 +136,7 @@ def run_command_and_log_output(command, log_file_path: Path):
"LD_LIBRARY_PATH": f"{os.getenv('PGCOPYDB_LIB_PATH')}:{os.getenv('PG_16_LIB_PATH')}",
"PGCOPYDB_SOURCE_PGURI": cast(str, os.getenv("BENCHMARK_INGEST_SOURCE_CONNSTR")),
"PGCOPYDB_TARGET_PGURI": cast(str, os.getenv("BENCHMARK_INGEST_TARGET_CONNSTR")),
"PGOPTIONS": "-c maintenance_work_mem=8388608 -c max_parallel_maintenance_workers=16",
"PGOPTIONS": "-c maintenance_work_mem=8388608 -c max_parallel_maintenance_workers=7",
}
# Combine the current environment with custom variables
env = os.environ.copy()
Expand Down
Loading