feat(client): only save forms if the value was changed

neopostmodern · Apr 30, 2023 · 76b61bb · 76b61bb
1 parent a6db8ef
commit 76b61bb
Show file tree

Hide file tree

Showing 3 changed files with 13 additions and 6 deletions.
diff --git a/client/src/renderer/components/LinkForm.tsx b/client/src/renderer/components/LinkForm.tsx
@@ -1,4 +1,4 @@
-import { pick } from 'lodash';
+import { isEqual, pick } from 'lodash';
 import React from 'react';
 import { FormProvider, useForm } from 'react-hook-form';
 import { LinkQuery } from '../generated/graphql';
@@ -48,7 +48,10 @@ const LinkForm: React.FC<LinkFormProps> = ({
         errors.url =
           'Not a valid URL – did you forget the protocol? (e.g. https://)';
       }
-      if (Object.keys(errors).length === 0) {
+      if (
+        Object.keys(errors).length === 0 &&
+        !isEqual(formValues, defaultValues)
+      ) {
         onSubmit(formValues);
       }
       return { values: formValues, errors };

diff --git a/client/src/renderer/components/TagForm.tsx b/client/src/renderer/components/TagForm.tsx
@@ -1,4 +1,4 @@
-import { pick } from 'lodash';
+import { isEqual, pick } from 'lodash';
 import React from 'react';
 import { useForm } from 'react-hook-form';
 import styled from 'styled-components';
@@ -53,7 +53,9 @@ const TagForm: React.FC<TagFormProps> = ({ tag, onSubmit }) => {
     mode: 'onBlur',
     resolver: (formValues) => {
       // todo: validate
-      onSubmit(formValues);
+      if (!isEqual(formValues, defaultValues)) {
+        onSubmit(formValues);
+      }
       return { values: formValues, errors: {} };
     },
   });

diff --git a/client/src/renderer/components/TextForm.tsx b/client/src/renderer/components/TextForm.tsx
@@ -1,4 +1,4 @@
-import { pick } from 'lodash';
+import { isEqual, pick } from 'lodash';
 import React from 'react';
 import { FormProvider, useForm } from 'react-hook-form';
 import { NotesForListQuery } from '../generated/graphql';
@@ -36,7 +36,9 @@ const TextForm: React.FC<TextFormProps> = ({
     defaultValues,
     mode: 'onBlur',
     resolver: (formValues) => {
-      onSubmit(formValues);
+      if (!isEqual(formValues, defaultValues)) {
+        onSubmit(formValues);
+      }
       return { values: formValues, errors: {} };
     },
   });