Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BUGFIX: Use new keyvisual in all languages #152

Merged
merged 1 commit into from
Dec 7, 2022
Merged

BUGFIX: Use new keyvisual in all languages #152

merged 1 commit into from
Dec 7, 2022

Conversation

Sebobo
Copy link
Member

@Sebobo Sebobo commented Dec 7, 2022

The new keyvisual was only set in US English.

markusguenther
markusguenther approved these changes Dec 7, 2022
View reviewed changes
Copy link
Member

@markusguenther markusguenther left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix. The heart is now green in English and red in the other languages, but as I changed it from blue to green for contrast reasons, it is ok, I guess.

@markusguenther markusguenther merged commit d583950 into 8.2 Dec 7, 2022
@markusguenther markusguenther deleted the bugfix/replace-keyvisual-in-all-languages branch December 7, 2022 11:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@markusguenther markusguenther markusguenther approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Sebobo @markusguenther