[BUGFIX] Disable authorization checks in functional tests

This adjusts the ``FunctionalTestCase`` base class to disable
authorization checks if the ``testableSecurityEnabled`` is not set.

Background:
If security is not enable for functional tests, the
``Security\\Context`` is not initialized. This leads to exceptions in
case the ``PolicyEnforcement`` kicks in. Because functional tests
inherit the configuration of the default contexts, this happens very
likely, especially when making use of node related privileges in Neos
sites.

Change-Id: Ie5977200368f65734a6b271357ef21306912cb62
Related: NEOS-5
Releases: master, 3.0
Original-Commit-Hash: 638d25cc9c09b7173f56f1e8e14d1e4f18562afd

TYPO3.Flow/Classes/TYPO3/Flow/Security/Context.php

@@ -647,6 +647,7 @@ public function clearContext() {
 		$this->request = NULL;
 		$this->csrfProtectionTokens = array();
 		$this->interceptedRequest = NULL;
+		$this->authorizationChecksDisabled = FALSE;
 		$this->initialized = FALSE;
 	}
 

TYPO3.Flow/Tests/FunctionalTestCase.php

@@ -162,9 +162,7 @@ public function setUp() {
 			$session->destroy(sprintf('assure that session is fresh, in setUp() method of functional test %s.', get_class($this) . '::' . $this->getName()));
 		}
 
-		if ($this->testableSecurityEnabled === TRUE) {
-			$this->setupSecurity();
-		}
+		$this->setupSecurity();
 	}
 
 	/**
@@ -175,30 +173,34 @@ public function setUp() {
 	 * @return void
 	 */
 	protected function setupSecurity() {
-		$this->privilegeManager = $this->objectManager->get('TYPO3\Flow\Security\Authorization\TestingPrivilegeManager');
-		$this->privilegeManager->setOverrideDecision(NULL);
+		$this->securityContext = $this->objectManager->get('TYPO3\Flow\Security\Context');
+		if ($this->testableSecurityEnabled) {
+			$this->privilegeManager = $this->objectManager->get('TYPO3\Flow\Security\Authorization\TestingPrivilegeManager');
+			$this->privilegeManager->setOverrideDecision(NULL);
 
-		$this->policyService = $this->objectManager->get('TYPO3\Flow\Security\Policy\PolicyService');
+			$this->policyService = $this->objectManager->get('TYPO3\Flow\Security\Policy\PolicyService');
 
-		$this->authenticationManager = $this->objectManager->get('TYPO3\Flow\Security\Authentication\AuthenticationProviderManager');
+			$this->authenticationManager = $this->objectManager->get('TYPO3\Flow\Security\Authentication\AuthenticationProviderManager');
 
-		$this->testingProvider = $this->objectManager->get('TYPO3\Flow\Security\Authentication\Provider\TestingProvider');
-		$this->testingProvider->setName('TestingProvider');
+			$this->testingProvider = $this->objectManager->get('TYPO3\Flow\Security\Authentication\Provider\TestingProvider');
+			$this->testingProvider->setName('TestingProvider');
 
-		$this->registerRoute('functionaltestroute', 'typo3/flow/test', array(
-			'@package' => 'TYPO3.Flow',
-			'@subpackage' => 'Tests\Functional\Mvc\Fixtures',
-			'@controller' => 'Standard',
-			'@action' => 'index',
-			'@format' => 'html'
-		));
+			$this->registerRoute('functionaltestroute', 'typo3/flow/test', array(
+				'@package' => 'TYPO3.Flow',
+				'@subpackage' => 'Tests\Functional\Mvc\Fixtures',
+				'@controller' => 'Standard',
+				'@action' => 'index',
+				'@format' => 'html'
+			));
 
-		$requestHandler = self::$bootstrap->getActiveRequestHandler();
-		$actionRequest = $this->route($requestHandler->getHttpRequest());
+			$requestHandler = self::$bootstrap->getActiveRequestHandler();
+			$actionRequest = $this->route($requestHandler->getHttpRequest());
 
-		$this->securityContext = $this->objectManager->get('TYPO3\Flow\Security\Context');
-		$this->securityContext->clearContext();
-		$this->securityContext->setRequest($actionRequest);
+			$this->securityContext->clearContext();
+			$this->securityContext->setRequest($actionRequest);
+		} else {
+			\TYPO3\Flow\Reflection\ObjectAccess::setProperty($this->securityContext, 'authorizationChecksDisabled', TRUE, TRUE);
+		}
 	}
 
 	/**
@@ -227,9 +229,7 @@ protected function route(Request $httpRequest) {
 	 * @return void
 	 */
 	public function tearDown() {
-		if ($this->testableSecurityEnabled === TRUE) {
-			$this->tearDownSecurity();
-		}
+		$this->tearDownSecurity();
 
 		$persistenceManager = self::$bootstrap->getObjectManager()->get('TYPO3\Flow\Persistence\PersistenceManagerInterface');
 
@@ -273,7 +273,10 @@ protected function tearDownSecurity() {
 		if ($this->securityContext !== NULL) {
 			$this->securityContext->clearContext();
 		}
-		\TYPO3\Flow\Reflection\ObjectAccess::setProperty($this->authenticationManager, 'isAuthenticated', NULL, TRUE);
+		if ($this->authenticationManager !== NULL) {
+			\TYPO3\Flow\Reflection\ObjectAccess::setProperty($this->authenticationManager, 'isAuthenticated', NULL, TRUE);
+		}
+
 	}
 
 	/**