Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

!!! TASK: Remove NodeSearchServiceInterface and implementation #4555

Merged
merged 1 commit into from
Oct 27, 2023

Conversation

mhsdesign
Copy link
Member

@mhsdesign mhsdesign commented Sep 23, 2023

Resolves: #3771

Upgrade instructions

before:

$nodes = $this->nodeSearchService->findByProperties(string $term, array $searchNodeTypes);

after:

$nodes = $this->subgraph->findDescendantNodes(
    $entryNode->nodeAggregateId,
    FindDescendantNodesFilter::create(
        nodeTypes: NodeTypeConstraints::create(
            NodeTypeNames::fromStringArray($searchNodeTypes),
            NodeTypeNames::createEmpty()
        ),
        searchTerm: $term,
    )
);

Review instructions

Checklist

  • Code follows the PSR-2 coding style
  • Tests have been created, run and adjusted as needed
  • The PR is created against the lowest maintained branch
  • Reviewer - PR Title is brief but complete and starts with FEATURE|TASK|BUGFIX
  • Reviewer - The first section explains the change briefly for change-logs
  • Reviewer - Breaking Changes are marked with !!! and have upgrade-instructions

@ahaeslich ahaeslich merged commit d4e7983 into 9.0 Oct 27, 2023
@ahaeslich ahaeslich deleted the task/90-remove-nodeSearchService branch October 27, 2023 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

TASK: re-implement NodeSearchService
4 participants