Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

META: CKE5 integration #2002

Closed
2 of 3 tasks
dimaip opened this issue Jul 12, 2018 · 4 comments
Closed
2 of 3 tasks

META: CKE5 integration #2002

dimaip opened this issue Jul 12, 2018 · 4 comments
Labels

Comments

@dimaip
Copy link
Contributor

dimaip commented Jul 12, 2018

How to test?

The default text editor is now configurable in Settings.yaml:

Neos:
  Neos:
    Ui:
      frontendConfiguration:
        defaultInlineEditor: 'ckeditor5'

TODO:

@dimaip dimaip added the Meta label Jul 12, 2018
@dimaip dimaip mentioned this issue Jul 12, 2018
3 tasks
@DrillSergeant
Copy link

@dimaip , could you change the handling of link-schemes in CKE5 integration? In CKE4 the possible schemes are mentioned in Packages/Application/Neos.Neos.Ui/packages/neos-ui-ckeditor-bindings/src/EditorToolbar/LinkIconButton.js in this construct:

const isUri = str =>
    str && Boolean(str.match('^(https?://|mailto:|tel:|#)'));

Sometimes (especially for intranet-projects) there are more url-schemes that should work (like "notes://" for lotus-notes documents). In CKE4 I cannot extend that because it's hardcoded and so it takes a lot of work to make linking to those schemed-links possible in RTE.
I would love if you could make this configurable via settings to add additional schemes so the CKE5-link editor accepts those custom schemes.
I just had a slack call with @kitsunet where he mentioned even some more ideas. Maybe you guys can talk/discuss. Remember, a simple solution for my usecase would help for many cases I think. I guess (hope) it's not so hard to check settings for some extra schemes.

@dimaip
Copy link
Contributor Author

dimaip commented Jul 19, 2018

@DrillSergeant it's no longer needed, you can type in any kind of link you'd want (even relative) and click save.

@DrillSergeant
Copy link

@dimaip ah nice, thank you.

dimaip added a commit to neos/neos-development-collection that referenced this issue Jul 25, 2018
neos-bot pushed a commit to neos/neos that referenced this issue Jul 26, 2018
@danielkestler
Copy link
Contributor

We can close this, can we?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants