BUGFIX: 3557 placeholder plugin with autoparagraph false #3558
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
So i was wondering why we even have our more or less hacky placeholder plugin. When we initially integrated CKEditor 5 #1942 its latest version was v10. And only with v12 the "ckeditor5-editor-decoupled" had native support for placeholders. see docs: https://ckeditor.com/docs/ckeditor5/16.0.0/api/module_core_editor_editorconfig-EditorConfig.html#member-placeholder and https://ckeditor.com/docs/ckeditor5/16.0.0/features/editor-placeholder.html luckily we use v12 in 7.3 and v16 in 8.3 so we can utilize this more stable native placeholder support as of right now. |
Sebobo
requested changes
Jul 3, 2023
Sebobo
approved these changes
Jul 3, 2023
mhsdesign
force-pushed
the
bugfix/3557-placeholder-plugin-autoparagraph-false
branch
from
42030fe to
19402f2
Compare
mhsdesign
added a commit
that referenced
this pull request
Oct 9, 2024
In Neos 7.3.17 and before the placeholder in ckeditor would not disappear when focused. And only when typing. By switching to the native placeholder feature of ckeditor in #3558 we introduced a regression as that implementation would hide the placeholder while just clicking into. This is especially noticeable for centered texts as the cursor needs one millisecond to adjust and its glitchy. This will eventually be fixed in Ckeditor 24 something. As a hotfix for our version 16 i introduce the patch of ckeditor/ckeditor5#8474 (without the css absolute change as that would make centered text uneditable). The mentioned fix was not merged directly into ckeditor but made way more complicated: ckeditor/ckeditor5#8867 We dont need the more complicated fix as we dont use the mentioned features of the placeholder in a image description and such.
markusguenther
added a commit
that referenced
this pull request
Oct 14, 2024
…3864) * BUGFIX: Restore old Placeholder behavior to keep shown when focused In Neos 7.3.17 and before the placeholder in ckeditor would not disappear when focused. And only when typing. By switching to the native placeholder feature of ckeditor in #3558 we introduced a regression as that implementation would hide the placeholder while just clicking into. This is especially noticeable for centered texts as the cursor needs one millisecond to adjust and its glitchy. This will eventually be fixed in Ckeditor 24 something. As a hotfix for our version 16 i introduce the patch of ckeditor/ckeditor5#8474 (without the css absolute change as that would make centered text uneditable). The mentioned fix was not merged directly into ckeditor but made way more complicated: ckeditor/ckeditor5#8867 We dont need the more complicated fix as we dont use the mentioned features of the placeholder in a image description and such. * TASK: Move cursor before the placeholer * TASK: Hide break in placeholder context To move the cursor to the first position, the placeholder text is moved backwards. Therefore, a change with a break is disadvantageous. --------- Co-authored-by: Markus Günther <info@unikka.de>
laurahaenel
pushed a commit
to laurahaenel/neos-ui
that referenced
this pull request
Oct 21, 2024
…eos#3864) * BUGFIX: Restore old Placeholder behavior to keep shown when focused In Neos 7.3.17 and before the placeholder in ckeditor would not disappear when focused. And only when typing. By switching to the native placeholder feature of ckeditor in neos#3558 we introduced a regression as that implementation would hide the placeholder while just clicking into. This is especially noticeable for centered texts as the cursor needs one millisecond to adjust and its glitchy. This will eventually be fixed in Ckeditor 24 something. As a hotfix for our version 16 i introduce the patch of ckeditor/ckeditor5#8474 (without the css absolute change as that would make centered text uneditable). The mentioned fix was not merged directly into ckeditor but made way more complicated: ckeditor/ckeditor5#8867 We dont need the more complicated fix as we dont use the mentioned features of the placeholder in a image description and such. * TASK: Move cursor before the placeholer * TASK: Hide break in placeholder context To move the cursor to the first position, the placeholder text is moved backwards. Therefore, a change with a break is disadvantageous. --------- Co-authored-by: Markus Günther <info@unikka.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves: #3557
as the placeholder plugin was a bit hacky and broke in a regression from #3532
Because
editor.getDatanow returned the new internal<neos-inline-wrapper>tags. The preprocessing to strip them is now applied earlier, so other calls toeditor.getDatanow get the expected results.also a problem is resolved that no placeholder is shown, if one chooses
h1tag whenautoparagraph falseis enabledadditionally it cleans up the codebase and uses the native ckeditor placeholder plugin instead of our hacky home-brewed solution.
before and after:
Bildschirmaufnahme.2023-07-03.um.10.13.27.mov
Bildschirmaufnahme.2023-07-03.um.10.15.44.mov
Bildschirmaufnahme.2023-07-03.um.10.14.14.mov
What I did
How I did it
How to verify it