8.4: fix e2e tests #3850
8.4: fix e2e tests #3850
Conversation
before this change, we got a DB migration error (presumably because of too new MySQL version)
…warning if unmounted (needed to have the tests run through)
|
Hm, I do not understand why the e2e tests still fail on CircleCI. Locally they run through now. @markusguenther @mhsdesign any ideas? :) ERROR Cannot find the browser. "saucelabs:Firefox@latest:Windows 10" is neither a known browser alias, nor a path to an executable file. All the best, |
There was a problem hiding this comment.
Hi @skurfuerst,
thanks a lot for taking care of this ❤️ I tested both make test-e2e-docker and make start-neos-dev-instance locally and they both work perfectly 👍
ERROR Cannot find the browser. "saucelabs:Firefox@latest:Windows 10" is neither a known browser alias, nor a path to an executable file.
Since you didn't touch CI, I suspect the error is on saucelabs' end (Wasn't there some EOL announcement lately?). We probably need to revise our CI strategy for the E2E tests, so I'd say it's fine to ignore the red check as far as this PR is concerned.
|
Thanks @grebaldi for testing and giving feedback <3 <3 |
| @@ -72,7 +72,9 @@ export default class ImageEditor extends Component { | |||
| isAssetLoading: true | |||
| }, () => { | |||
| this.loadImage = loadImageMetadata(this.props.value.__identity).then(image => { | |||
| this.setState({image, isAssetLoading: false}); | |||
| if (this._isMounted) { | |||
There was a problem hiding this comment.
this probably fixes the flacky cropping tests? I also experienced issues here ^^
| * for example, this runs all tests in chrome: | ||
| `yarn run testcafe chrome Tests/IntegrationTests/Fixtures` | ||
| * for example, this runs all tests in chrome: (NOTE starting with Chrome 127, --disable-search-engine-choice-screen is needed) | ||
| `yarn run testcafe chrome:--disable-search-engine-choice-screen Tests/IntegrationTests/Fixtures/1Dimension` |
There was a problem hiding this comment.
thanks for the --disable-search-engine-choice-screen hint its really stupid of chrome :D
|
Will upmerge today |
8.4: fix e2e tests # Conflicts: # packages/neos-ui-redux-store/src/CR/Nodes/selectors.ts
This change fixes the TestCafe Setup