RFC: Rename neosmart_event_t to pevent_t #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The original name was an attempt to keep with the naming conventions used by the pthreads library, along the lines of `libname_objname_t`. However, it doesn't seem necessary or proper to do so if we are using C++ with the code in the `neosmart` namespace.
It also doesn't seem correct to use `pthread_event_t` as the name if the event object is not part of the `pthread` library proper, even if it is built atop of it. Furthermore, there's no need for the name to be so long and wordy if we have the advantage of C++ namespacing, since there's no risk of a name collision.
mqudsi
changed the title
mqudsi
force-pushed
the
master
branch
2 times, most recently
from
a60ccc6
to
9c22e4e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm opening this as a request for comments in case anyone has any feedback before squash-merging the commits in this PR into the
masterbranch.The rationale for using
pevent_tinstead of the previousneosmart_event_tor the other option ofpthread_event_t(which is probably the "classiest" option) is described in the commit messages: