Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(buf): new lsp for protobuf #3414

Merged
merged 6 commits into from
Nov 6, 2024
Merged

feat(buf): new lsp for protobuf #3414

merged 6 commits into from
Nov 6, 2024

Conversation

gogamid
Copy link
Contributor

@gogamid gogamid commented Nov 1, 2024

As may know, bufbuild team is working on the new lsp for protobufs which is included in the cli itself. Compared to buf-language-server, this lsp supports more features. Take a look at this PR for more info. This config sets up the new buf lsp.

@gogamid gogamid requested a review from glepnir as a code owner November 1, 2024 15:37
@gogamid gogamid changed the title feat: new lsp for protobuf feat(buf): new lsp for protobuf Nov 2, 2024
@gogamid
Copy link
Contributor Author

gogamid commented Nov 2, 2024

finally fixed the linter problems :D

Copy link

@sprsquish sprsquish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for posting this!

qq: are you having problems with the LSP timing out and exiting? When I was playing with this I had to set --timeout=0 or the LSP would exit.
I'd also suggest adding --log-format=text. The default is color and it makes the logs hard to read

@gogamid
Copy link
Contributor Author

gogamid commented Nov 2, 2024

@sprsquish yeah, i got occasional crash, i thought because the lsp is still in beta phase. But good suggestions!

@glepnir
Copy link
Member

glepnir commented Nov 3, 2024

the old bufls can mark as deprecated ? and current server file name is a bit confusing. I think it is better to use xx_ls.lua as the file name if there is no special server command name.

@glepnir
Copy link
Member

glepnir commented Nov 4, 2024

https://github.com/bufbuild/buf-language-server this repo is archived so could you also add a deprecate of bufls in lua/lspconfig.lua aliases table ?

@gogamid
Copy link
Contributor Author

gogamid commented Nov 5, 2024

@glepnir done

@glepnir glepnir merged commit 2e92288 into neovim:master Nov 6, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants