-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(buf): new lsp for protobuf #3414
Conversation
finally fixed the linter problems :D |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for posting this!
qq: are you having problems with the LSP timing out and exiting? When I was playing with this I had to set --timeout=0
or the LSP would exit.
I'd also suggest adding --log-format=text
. The default is color and it makes the logs hard to read
@sprsquish yeah, i got occasional crash, i thought because the lsp is still in beta phase. But good suggestions! |
the old bufls can mark as deprecated ? and current server file name is a bit confusing. I think it is better to use xx_ls.lua as the file name if there is no special server command name. |
https://github.com/bufbuild/buf-language-server this repo is archived so could you also add a deprecate of bufls in lua/lspconfig.lua aliases table ? |
@glepnir done |
As may know, bufbuild team is working on the new lsp for protobufs which is included in the cli itself. Compared to buf-language-server, this lsp supports more features. Take a look at this PR for more info. This config sets up the new buf lsp.