Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: deprecate util.find_node_modules_ancestor #3477

Merged

Conversation

dundargoc
Copy link
Member

@dundargoc dundargoc commented Nov 28, 2024

Work on #2079.

@dundargoc dundargoc force-pushed the refactor/find_node_modules_ancestor branch from 8e83644 to bb64fe3 Compare November 28, 2024 20:41
@dundargoc dundargoc force-pushed the refactor/find_node_modules_ancestor branch 2 times, most recently from 24dcc1c to f12093e Compare November 28, 2024 22:47
@dundargoc dundargoc marked this pull request as ready for review November 29, 2024 11:18
@dundargoc dundargoc requested a review from glepnir as a code owner November 29, 2024 11:18
@dundargoc dundargoc force-pushed the refactor/find_node_modules_ancestor branch 2 times, most recently from ff33317 to 8c14156 Compare November 30, 2024 11:28
@dundargoc dundargoc force-pushed the refactor/find_node_modules_ancestor branch 2 times, most recently from bd5d0ff to e5a09a5 Compare November 30, 2024 12:13
@dundargoc
Copy link
Member Author

dundargoc commented Nov 30, 2024

@justinmk should we wait for the minimum supported version to be 0.10 before we do this because of vim.fs.root? Right now, the replacement we can use is vim.fs.find('node_modules', {path='/Users/dundargoc/test/a', upwards=true})[1]

@glepnir

This comment was marked as resolved.

@dundargoc

This comment was marked as resolved.

@glepnir

This comment was marked as resolved.

@dundargoc dundargoc force-pushed the refactor/find_node_modules_ancestor branch 2 times, most recently from b47c8ea to 7908bfe Compare November 30, 2024 13:00
@justinmk
Copy link
Member

justinmk commented Dec 1, 2024

hould we wait for the minimum supported version to be 0.10 before we do this because of vim.fs.root? Right now, the replacement we can use is vim.fs.find('node_modules', {path='/Users/dundargoc/test/a', upwards=true})[1]

No, let's move forward with this. But let's also mention vim.fs.root in the "breadcrumbs" note "if you have Nvim 0.10 or newer".

@dundargoc dundargoc force-pushed the refactor/find_node_modules_ancestor branch from 7908bfe to b762d79 Compare December 1, 2024 22:28
@dundargoc dundargoc merged commit 19626a3 into neovim:master Dec 8, 2024
11 checks passed
@dundargoc dundargoc deleted the refactor/find_node_modules_ancestor branch December 8, 2024 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants