Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename nvim_lsp to lspconfig #348

Merged
merged 3 commits into from
Nov 15, 2020
Merged

Rename nvim_lsp to lspconfig #348

merged 3 commits into from
Nov 15, 2020

Conversation

h-michael
Copy link
Contributor

resolve #97
related #334

This PR includes breaking changes as it involves changing the name of the module.
There is also a discussion in #334 about whether to remove the installer or stop using monorepo.
I think it's better to make these changes at the same time because multiple breaking changes in a short period of time can be confusing to users.

@h-michael h-michael added the enhancement New feature or request label Sep 6, 2020
@justinmk
Copy link
Member

justinmk commented Sep 6, 2020

LGTM

This PR includes breaking changes as it involves changing the name of the module.

Let's define a nvim_lsp module that returns an error and/or shows a :echomsg like

NOTICE: "nvim_lsp" module was renamed to "lspconfig". Update your config/plugins to require('lspconfig') instead of require('nvim_lsp').

@tjdevries
Copy link

I don't remember if we've talked about this before, but what about vim.lsp.config?

@justinmk
Copy link
Member

justinmk commented Sep 7, 2020

I don't remember if we've talked about this before, but what about vim.lsp.config?

But it isn't part of the lsp module. It's a separate extension. So why name it like it is ? That seems actively confusing for no reason.

Lots of variants were suggested in #97

@teto
Copy link
Member

teto commented Oct 26, 2020

if we target a christmas release, may be good to proceed as early as possible, even if just for the rename (nvim_lsp to lspconfig)

@h-michael
Copy link
Contributor Author

@tjdevries @teto
Sorry for toooooo late replying. I've added a deprecated message.

@h-michael h-michael marked this pull request as ready for review November 1, 2020 05:32
@h-michael h-michael merged commit 42a13e5 into neovim:master Nov 15, 2020
@h-michael h-michael deleted the rename branch November 15, 2020 06:15
lithammer added a commit to lithammer/nvim-pylance that referenced this pull request Nov 15, 2020
vipulmathur added a commit to yoda-droid/erikstmartin-dotfiles that referenced this pull request Dec 1, 2020
This change is needed in `completion.vim` due to the upstream
name change neovim/nvim-lspconfig#348
vipulmathur added a commit to yoda-droid/erikstmartin-dotfiles that referenced this pull request Dec 1, 2020
This change is needed in `completion.vim` due to the upstream
name change neovim/nvim-lspconfig#348
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

rename to nvim-lspconfig
4 participants