-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename nvim_lsp to lspconfig #348
Conversation
d9459ec
to
5ac126a
Compare
LGTM
Let's define a
|
I don't remember if we've talked about this before, but what about vim.lsp.config? |
But it isn't part of the Lots of variants were suggested in #97 |
if we target a christmas release, may be good to proceed as early as possible, even if just for the rename (nvim_lsp to lspconfig) |
@tjdevries @teto |
This change is needed in `completion.vim` due to the upstream name change neovim/nvim-lspconfig#348
This change is needed in `completion.vim` due to the upstream name change neovim/nvim-lspconfig#348
resolve #97
related #334
This PR includes breaking changes as it involves changing the name of the module.
There is also a discussion in #334 about whether to remove the installer or stop using monorepo.
I think it's better to make these changes at the same time because multiple breaking changes in a short period of time can be confusing to users.