refactor: deprecate util.find_git_ancestor #3507
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dundargoc
force-pushed
the
refactor/find_git_ancestor
branch
2 times, most recently
from
b60bbb3 to
1b2444c
Compare
glepnir
reviewed
Dec 14, 2024
lua/lspconfig/util.lua
Outdated
| @@ -393,4 +383,9 @@ function M.find_package_json_ancestor(startpath) | |||
| return vim.fs.dirname(vim.fs.find('package.json', { path = startpath, upward = true })[1]) | |||
| end | |||
|
|
|||
| --- @deprecated use `vim.fs.find('.git', { path = startpath, upward = true })[1]` instead | |||
| function M.find_git_ancestor(startpath) | |||
| return vim.fs.find('.git', { path = startpath, upward = true })[1] | |||
There was a problem hiding this comment.
use vim.fs.dirname to get parent dir of result { "/Users/mw/workspace/neovim/.git" }
There was a problem hiding this comment.
Considering this is a very common situation, maybe it is better to add parent = true to the filter table
There was a problem hiding this comment.
You mean we add parent as an option to vim.fs.find? But we already have vim.fs.root that does what we want, we just can't use it right now since we support 0.9. Eventually we can drop that and start using vim.fs.root, and won't need to adjust vim.fs.find.
dundargoc
force-pushed
the
refactor/find_git_ancestor
branch
4 times, most recently
from
12f3c41 to
3d488da
Compare
dundargoc
force-pushed
the
refactor/find_git_ancestor
branch
from
3d488da to
4d4de10
Compare
justinmk
approved these changes
Dec 14, 2024
21 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Work on #2079.